Go Back   Web Scribble Forums » Joomla » jConnector
Reply
 
LinkBack Thread Tools Display Modes
  #1 (permalink)  
Old 12-12-2009, 09:15 AM
Junior Member
 
Join Date: Dec 2009
Location: New Hampshire
Posts: 2
Default Code Updates - Request for Review / inclusion

The version of JConnector I downloaded last night has a few coding issues.

None of the files are marked, but maybe v1.5.8 ?

Issues;
  • Table Check - tries to call table that may not exist, rather than checking for table - this throws a 500 error for the bad query "select * from pre_comprofiler limit 0,1" (addressed)
  • Calls the CB methods anyway (addressed)
  • Uses FB ID as user ID (rather than DB's auto-increment) which could cause obvious problems if user already exists with that ID (and makes linking table irrelevant)(addressed)

I have (under terms of GPL) made several corrections/updates to the code, and it now runs smooth on my site save one issue.

It is still not requesting the proxy email permission properly, so no email is returned or saved. I even did a screen dump of the entire user array returned by FB, and no email was included. I don't know enough about the PHP5 FB Client, or the FB API to resolve that last night, but I am working on it.

---

Request to Web Scribbles
How do I submit my code changes for review / inclusion ?




---

Anyone with FB API experience, I would love the hlp fixing this remaining email issue. I can handle the Joomla/PHP aspect if we can just get FB to return the proxied email.

Ideally we should be able to include the permission request in the initial "connect" request - but I am just not sure yet how to do that.

Regards,

Eddie
Reply With Quote
  #2 (permalink)  
Old 12-19-2009, 05:47 PM
Web Scribble Staff
 
Join Date: Jul 2009
Posts: 91
Default

Hi Eddie,

Thanks for the contribution! Please send them to support at webscribble.com.
Reply With Quote
  #3 (permalink)  
Old 12-19-2009, 10:58 PM
Junior Member
 
Join Date: Oct 2009
Posts: 16
Default

I think another user already sent some implementation for that. Look at this: Weird email showing for registered user Why?
He might be able to help with what you are asking for.
Reply With Quote
  #4 (permalink)  
Old 01-24-2010, 07:02 PM
Junior Member
 
Join Date: Jan 2010
Posts: 3
Reply

Tags
code, database, email, mysql

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


All times are GMT -5. The time now is 09:20 AM.